Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies Update, New Tray Behavior, and some random improvements :) #278

Merged
merged 33 commits into from
Oct 9, 2023
Merged

Dependencies Update, New Tray Behavior, and some random improvements :) #278

merged 33 commits into from
Oct 9, 2023

Conversation

bagusnl
Copy link
Member

@bagusnl bagusnl commented Sep 29, 2023 •
edited by Cryotechnic
Loading

Build-Canary
In this PR:

  • [IMP] Added MSBuild optimization for those using CoW based FS for their Git repository (eg. ReFS)
  • [NEW] Add Git short SHA where the build is compiled on console
  • [IMP] Update CommandLine to beta4 (bugfixes, NativeAOT Compile and ILTrim), include all adjustments necessary
  • [VULN] Update HTTP and Regex NuGet (CVE-2019-0820)
  • [NEW] New TrayIcon using H.NotifyIcon
  • [NEW] Add new start argument to start Collapse on system tray

TODO (ON NEXT PR):

Template:
[FIX]
[IMP]
[VUL]
[NEW]

@bagusnl
Add optimization for DevDrive
40afb67 
Use transitive copy for MSBuild to speed up build when using CoW file system like ReFS
@bagusnl
Add git commit description on console
275d0b6
@bagusnl
There was an attempt to update CommandLine to beta4
4babf9e 
This update brings some fixes but more importantly trimmable CommandLine NuGet package, including nativeAOT compilation. Though due to the removal of SetHandler, it has major changes in the code.

needs extensive review @neon-nyan
@bagusnl
ArgumentParser fixes
5945272 
- Fix unexpected early end bracket
- Cleanup unnecessary string statements
- Fix some arguments migrations misses
@bagusnl
Rebase to main at 7d3637
f065b6c
@bagusnl
Add a3b1c6
c31aa0e
@bagusnl
Bump to origin at 9d86c0
57abe9d
@bagusnl
Bump to origin at 39dea6
74de602
@bagusnl
Update nuget lock file
983b247
@bagusnl
Bump to origin at 90cd51
f2b51e3
@bagusnl
[VULN] Update Http and Regex NuGet
b4e2f11 
Due to high severity vulnerability that those have, update is necessary

.Net.Http (4.3.0 -> 4.3.4)
GHSA-7jgj-8wvc-jh57

.Text.RegularExpression
https://msrc.microsoft.com/update-guide/en-US/vulnerability/CVE-2019-0820
@bagusnl
Early implementation for Taskbar
40299e7
@bagusnl
Make Taskbar toggle text change on condition
5294d1c
@bagusnl
Add argument to start Collapse in tray
be911bd
@bagusnl bagusnl added Enhancement New feature or request Fixed Issue has been fixed Area: Runtime Issue labeled for runtime, Hi3Helper.Core and other libraries used by Collapse Area: Launcher Issue labeled for Launcher update mechanism Area: UI/UX Issue labeled for User Interface/eXperience related issue labels Sep 29, 2023
@bagusnl bagusnl self-assigned this Sep 29, 2023
@bagusnl bagusnl marked this pull request as draft September 29, 2023 19:41
@bagusnl
Bump to origin at b714d5
2bffb85
@bagusnl
Taskbar Improvements
7b100ca 
- Add console hiding method (thanks @muscularcandy67)
- Initialize locales
- Add function to show Collapse windows to foreground
- Add double click function to toggle both visibility
- Handle toggle string with StartonTray AppMode
Co-authored-by: Iskandar Montano <[email protected]>
@bagusnl
Use locales for TrayIcon
436c26c
@bagusnl bagusnl marked this pull request as ready for review October 7, 2023 17:22
@bagusnl
Bump to origin at f463aa
309c188
@bagusnl
Update Package References
f33787b 
- Delete unused CsWinRT
- Include packages to TrimmableAssembly
@bagusnl
Eliminate Flipflop Situation for ToggleAllVisibility
33a5fa1
@bagusnl
TrayIcon.xaml.cs Cleanup
6fd4f57 
- Add documentations
- Remove unused lastConsoleStatus
- Adjust locales statics
- Regionalize
neon-nyan
neon-nyan approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@neon-nyan neon-nyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! LGTM

Cryotechnic
Cryotechnic approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@Cryotechnic Cryotechnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have some commits OTW which will fix some of the issues discussed internally

CollapseLauncher/App.xaml.cs Outdated Show resolved Hide resolved
muscularcandy67
muscularcandy67 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@muscularcandy67 muscularcandy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@Cryotechnic Cryotechnic merged commit c89f687 into main Oct 9, 2023
@bagusnl bagusnl deleted the bagel-improvements branch December 3, 2023 14:56
@neon-nyan neon-nyan added this to the v1.72.x milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryotechnic Cryotechnic Cryotechnic approved these changes

@muscularcandy67 muscularcandy67 muscularcandy67 approved these changes

@neon-nyan neon-nyan neon-nyan approved these changes

Assignees

@bagusnl bagusnl

Labels
Area: Launcher Issue labeled for Launcher update mechanism Area: Runtime Issue labeled for runtime, Hi3Helper.Core and other libraries used by Collapse Area: UI/UX Issue labeled for User Interface/eXperience related issue Enhancement New feature or request Fixed Issue has been fixed
Projects
None yet
Milestone
v1.72.x
Development

Successfully merging this pull request may close these issues.
4 participants
@bagusnl @Cryotechnic @muscularcandy67 @neon-nyan